fix(kinesis): set required dimensions for Firehose quota metrics (#378)

According to AWS Docs [here](https://docs.aws.amazon.com/firehose/latest/dev/monitoring-with-cloudwatch-metrics.html), all firehose metrics require 'DeliveryStreamName' for filtering, this include Bytes, Records and PutRequest Per Second Limit metrics. Fixes bug where firehose quota limits metrics not working. --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
cdklabs · Jun 8, 2023 · 957e173 · 957e173
1 parent e9cb81c
commit 957e173
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/monitoring/aws-kinesis/KinesisFirehoseMetricFactory.ts b/lib/monitoring/aws-kinesis/KinesisFirehoseMetricFactory.ts
@@ -151,7 +151,7 @@ export class KinesisFirehoseMetricFactory {
       "BytesPerSecondLimit",
       MetricStatistic.AVERAGE,
       "Incoming Bytes/s Limit",
-      undefined,
+      this.dimensionsMap,
       undefined,
       FirehoseNamespace
     );
@@ -162,7 +162,7 @@ export class KinesisFirehoseMetricFactory {
       "RecordsPerSecondLimit",
       MetricStatistic.AVERAGE,
       "Records/s Limit",
-      undefined,
+      this.dimensionsMap,
       undefined,
       FirehoseNamespace
     );
@@ -173,7 +173,7 @@ export class KinesisFirehoseMetricFactory {
       "PutRequestsPerSecondLimit",
       MetricStatistic.AVERAGE,
       "PutRequests/s Limit",
-      undefined,
+      this.dimensionsMap,
       undefined,
       FirehoseNamespace
     );

diff --git a/test/monitoring/aws-kinesis/__snapshots__/KinesisFirehoseMonitoring.test.ts.snap b/test/monitoring/aws-kinesis/__snapshots__/KinesisFirehoseMonitoring.test.ts.snap