Skip to content

Commit

Permalink
fix: use LESS_THAN_THRESHOLD for addMinUsageCountAlarm (#318)
Browse files Browse the repository at this point in the history
`LESS_THAN_LOWER_THRESHOLD` is for:

```
* Specified statistic is lower than the anomaly model band.
* Used only for alarms based on anomaly detection models
```

...which is not what it was being used for.

---

_By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
  • Loading branch information
echeung-amzn authored Jan 28, 2023
1 parent fdd5ac1 commit 07d9896
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion lib/common/monitoring/alarms/UsageAlarmFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class UsageAlarmFactory {
props.treatMissingDataOverride ?? TreatMissingData.MISSING,
comparisonOperator:
props.comparisonOperatorOverride ??
ComparisonOperator.LESS_THAN_LOWER_THRESHOLD,
ComparisonOperator.LESS_THAN_THRESHOLD,
...props,
disambiguator,
threshold: props.minCount,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 07d9896

Please sign in to comment.