feat: Reference aws-cdk-lib and constructs as peer and dev dependencies so that they are not unnecessarily get bundled #996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem
As part of the investigation for an issue with aws-cdk, I find that aws-cdk-lib and constructs are bundled up since they're specified as dependencies of cdk-ecr-deployment. Searching for
P181556369
in the internal ticketing system for details.Proposed Solution
Reference aws-cdk-lib and constructs as peer and dev dependencies so that they are not unnecessarily get bundled.
The following example illustrates that PeerDependencies are not automatically bundled.
package.json of an app
package-a/package.json