Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ability to change the architecture of the lambda #364

Closed
wants to merge 1 commit into from

Conversation

TheGoatedDev
Copy link

Added as of the issues when deploying on a X86_64 Lambda Function with a ARM64 DockerImage.

@TheGoatedDev TheGoatedDev changed the title Added ability to change the Architecture of the Lambda feat: added ability to change the architecture of the lambda Oct 6, 2023
@evgenyka evgenyka requested a review from wchaws November 2, 2023 10:00
@wchaws wchaws self-requested a review November 3, 2023 02:49
@wchaws
Copy link
Contributor

wchaws commented Nov 3, 2023

Please fix the build error firstly

@uncledru
Copy link

@TheGoatedDev would you mind addressing the PR comments? would appreciate if this landed

@TheGoatedDev
Copy link
Author

Hi @uncledru,
Sorry that I haven't been able to be able to get back to fixing this issue, I don't have much time spare and the personal need for this feature is no longer a top-priority, you are free to fix the build and I will happily do the PR Reviews so that we can move this forward, if you do it on my fork.

@uncledru
Copy link

uncledru commented Mar 15, 2024

Hi @uncledru, Sorry that I haven't been able to be able to get back to fixing this issue, I don't have much time spare and the personal need for this feature is no longer a top-priority, you are free to fix the build and I will happily do the PR Reviews so that we can move this forward, if you do it on my fork.

After digging a bit deeper, I realized I needed a slightly different change. Would appreciate a review if you have a moment: #570

@mrgrain
Copy link
Contributor

mrgrain commented Oct 8, 2024

This one is further along: #570

@mrgrain mrgrain closed this Oct 8, 2024
auto-merge was automatically disabled October 8, 2024 09:49

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants