Skip to content

Commit

Permalink
chore(deps): aws-cdk-lib and constructs are now peer dependencies (#998)
Browse files Browse the repository at this point in the history
Construct libraries should always specify peer dependencies on
aws-cdk-lib and constructs, not regular dependencies. To get this to
build I needed to upgrade the min compatible CDK version to 2.80.0, but
there are some vulnerabilities in earlier versions of CDK v2 anyway so
that is a good thing.

cc @xiongbo-sjtu
  • Loading branch information
kaizencc authored Dec 24, 2024
1 parent 06d273f commit b9532d1
Show file tree
Hide file tree
Showing 6 changed files with 36 additions and 72 deletions.
12 changes: 1 addition & 11 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const project = new CdklabsConstructLibrary({
private: false,
author: 'wchaws',
authorAddress: 'https://aws.amazon.com',
cdkVersion: '2.0.0',
cdkVersion: '2.80.0',
cdkVersionPinning: false,
defaultReleaseBranch: 'main',
majorVersion: 3,
Expand All @@ -26,8 +26,6 @@ const project = new CdklabsConstructLibrary({
'hpagent',
],
deps: [
'aws-cdk-lib@^2.0.0',
'constructs@^10.0.5',
'got',
'hpagent',
], /* Runtime dependencies of this module. */
Expand Down
16 changes: 1 addition & 15 deletions API.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 29 additions & 39 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b9532d1

Please sign in to comment.