chore: unit test the aws module
#44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10257976005 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10275852420 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10293667126 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10311424404 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10327336851 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10335506332 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10361382461 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10375384595 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10396583277 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10412445470 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10427873300 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10436277052 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10462960595 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10481180148 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10499497071 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10517607562 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10534036294 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10551287221 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-assets/actions/runs/10569355571 ------ *Automatically created by projen via the "upgrade-main" workflow*
iliapolo
commented
Aug 27, 2024
| }); | ||
| }); | ||
|
|
||
| export function withMocked<A extends object, K extends keyof A, B>( |
There was a problem hiding this comment.
|
Intentionally targeted to |
|
Closing. The changes here will be included in #40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have unit tests that assert the behavior of the
DefaultAwsClientin theaws.tsmodule. This means that, for example, we don't assert that when it assumes a role, it passes all necessary arguments to theAWS.ChainableTemporaryCredentialsfunction. This PR adds the ground work for adding such tests, as well as two starter tests which cover the above mentioned gap.