chore: emit Docker and Shell logging to ProgressListener #221
+555
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
reviewed
Dec 10, 2024
mrgrain
reviewed
Dec 10, 2024
mrgrain
requested changes
Dec 10, 2024
BTW, if it doesn't close the issue, e.g. because a second PR is needed, you cannot put that in like that. |
HBobertz
changed the title
HBobertz
changed the title
Signed-off-by: github-actions <[email protected]>
HBobertz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #196
There is still a quiet flag however I will do that in another pr.
This change adds a new
GlobalOutputHandlerwhich as the name implies, is a global object which will send messages to the progress listener. If invoked from the CLI, the CLI first configures the progress as aConsoleProgress()listener which prints to stderr by default. If invoked fromAssetPublishing(the class which we programmatically interact with from the aws-cdk), then the globalOutputHandler will instead push the messages to the progress listener defined in that class.