Skip to content

Commit

Permalink
chore: bump mock-fs to fix tests on Node 20 (#168)
Browse files Browse the repository at this point in the history
`mock-fs@4` doesn't work on Node 20. `mock-fs@5` does.
  • Loading branch information
rix0rrr authored Nov 6, 2024
1 parent 6c5b4b1 commit 7df48a5
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const project = new typescript.TypeScriptProject({
'fs-extra',
'graceful-fs',
'jszip',
'mock-fs',
'mock-fs@^5',
],
packageName: 'cdk-assets',
eslintOptions: {
Expand Down
2 changes: 1 addition & 1 deletion package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/files.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ describe('external assets', () => {
test('fails when we dont have access to the bucket', async () => {
const pub = new AssetPublishing(AssetManifest.fromPath('/simple/cdk.out'), { aws });

aws.mockS3.getBucketLocation = jest.fn().mockImplementation((req: any) => {
aws.mockS3.getBucketLocation = jest.fn().mockImplementation((_req: any) => {
return {
promise: () => {
throw errorWithCode('AccessDenied', 'Whatever');
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7df48a5

Please sign in to comment.