Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't diff db on main #781

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 20, 2023

Makes the currently "failing" build on main pass by bypassing the diff-db job that is not useful on main.
With this we can actually see if everything is alright on main by looking at the status of the latest commit.

image

Copy link

github-actions bot commented Dec 20, 2023

@aws-cdk/aws-service-spec: No model change detected

@mrgrain mrgrain force-pushed the mrgrain/chore/no-diff-db-on-main branch from 6f725fe to 62a704a Compare December 20, 2023 12:48
@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 20, 2023

Why did the job fail? Because it can't post a comment?

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit 9a24c64 Dec 20, 2023
9 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/chore/no-diff-db-on-main branch December 20, 2023 14:14
@mrgrain
Copy link
Contributor Author

mrgrain commented Dec 20, 2023

Why did the job fail? Because it can't post a comment?

The job compares the DB of head vs base. Outside of the context of a PR (or any other branch) that you want to merge into main the job will never be useful. But yes, did fail because there is no PR to do a comment with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants