Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service-spec-types): index for scrutinizable resources #669

Closed
wants to merge 1 commit into from

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 3, 2023

Will be used by @aws-cdk/cloudfromation-diff.

} from './resource';

export function emptyDatabase() {
return new Database(
{
resource: entityCollection<Resource>().index({
cloudFormationType: fieldIndex('cloudFormationType', stringCmp),
scrutinizable: fieldIndexWithDefault('scrutinizable', stringCmp, ResourceScrutinyType.None),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up doing this instead of using an index that can understand undefined because querying db.lookup('resource', 'scrutinizable', 'equals', ResourceScrutinyType.None) is nicer.

Copy link

github-actions bot commented Nov 3, 2023

@aws-cdk/aws-service-spec: No model change detected

@mrgrain mrgrain marked this pull request as draft November 3, 2023 12:15
auto-merge was automatically disabled November 3, 2023 12:15

Pull request was converted to draft

@mrgrain
Copy link
Contributor Author

mrgrain commented Nov 3, 2023

Although I might not even needed this. 🤔

@mrgrain mrgrain closed this Nov 3, 2023
@rix0rrr rix0rrr deleted the mrgrain/feat/scrutinizable-index branch November 3, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants