Skip to content

Commit

Permalink
feat(sources): update cfn-schema (#847)
Browse files Browse the repository at this point in the history
> ⚠️ This Pull Request updates daily and will overwrite **all** manual
changes pushed to the branch

Updates the cfn-schema source from upstream. See details in [workflow
run].

[Workflow Run]:
https://github.com/cdklabs/awscdk-service-spec/actions/runs/7670276335

------

*Automatically created by projen via the "update-source-cfn-schema"
workflow*

---------

Signed-off-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Kaizen Conroy <[email protected]>
Co-authored-by: Kaizen Conroy <[email protected]>
  • Loading branch information
4 people authored Jan 26, 2024
1 parent c1481de commit b4f0774
Show file tree
Hide file tree
Showing 32 changed files with 67 additions and 71 deletions.
18 changes: 13 additions & 5 deletions packages/@aws-cdk/service-spec-importers/src/resource-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,20 @@ export class ResourceBuilder extends PropertyBagBuilder {
continue;
}

const prop = this.propertyDeep(...propPath);
if (prop) {
this.setAttribute(propWithPeriods, prop);
try {
const prop = this.propertyDeep(...propPath);
if (prop) {
this.setAttribute(propWithPeriods, prop);

// FIXME: not sure if we need to delete property `Foo` if the only
// attribute reference we got is `Foo/Bar`. Let's not for now.
// FIXME: not sure if we need to delete property `Foo` if the only
// attribute reference we got is `Foo/Bar`. Let's not for now.
}
} catch (e: any) {
// We're catching any errors from propertyDeep because CloudFormation allows schemas
// where attribute properties are not part of the spec anywhere else. Although it is
// likely a bad schema, CDK forges ahead by just dropping the attribute.
// Example: `ProviderDetails` typed as `Map<string,string>` and `"readOnlyProperties: ['/properties/ProviderDetails/Attribute']"`
console.log(`Attribute cannot be found in the spec. Error returned: ${e}.`);
}
}
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions sources/CloudFormationSchema/us-east-2/aws-kendra-faq.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b4f0774

Please sign in to comment.