Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport): action failing due to upstream bug #1446

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

iliapolo
Copy link
Member

@iliapolo iliapolo commented Nov 24, 2022

The backport action is currently failing because of a bug with the new version of the backport tool.

This PR pins the version to a working one for now. Note that the backport tool isn't mentioned as a normal devDependency because it requires Node 16, and our builds run with Node 14. We could hack the workflows somehow to use Node16 for installation, and then go back to Node 14 for building, but thats not really needed. The backport action runs in a dedicated workflow that just uses Node 16 for everything.

Signed-off-by: Eli Polonsky <[email protected]>
Signed-off-by: Eli Polonsky <[email protected]>
@iliapolo iliapolo merged commit 66cec8b into k8s-25/main Nov 24, 2022
@iliapolo iliapolo deleted the epolon/pin-backport-version branch November 24, 2022 16:24
@cdk8s-automation
Copy link
Contributor

💔 All backports failed

Status Branch Result
k8s-23/main Backport failed because of merge conflicts
k8s-24/main Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 1446

Questions ?

Please refer to the Backport tool documentation

iliapolo added a commit that referenced this pull request Nov 24, 2022
(cherry picked from commit 66cec8b)
Signed-off-by: Eli Polonsky <[email protected]>

# Conflicts:
#	.projen/tasks.json
@iliapolo
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
k8s-24/main

Questions ?

Please refer to the Backport tool documentation

iliapolo added a commit that referenced this pull request Nov 24, 2022
(cherry picked from commit 66cec8b)
Signed-off-by: Eli Polonsky <[email protected]>

# Conflicts:
#	.projen/tasks.json
@iliapolo
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
k8s-23/main

Questions ?

Please refer to the Backport tool documentation

iliapolo added a commit that referenced this pull request Nov 24, 2022
(cherry picked from commit 66cec8b)
Signed-off-by: Eli Polonsky <[email protected]>

# Conflicts:
#	.projen/tasks.json
iliapolo added a commit that referenced this pull request Nov 24, 2022
(cherry picked from commit 66cec8b)
Signed-off-by: Eli Polonsky <[email protected]>

# Conflicts:
#	.projen/tasks.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants