Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): add nextcloud #14

Closed
wants to merge 17 commits into from
Closed

chore(examples): add nextcloud #14

wants to merge 17 commits into from

Conversation

SmsS4
Copy link

@SmsS4 SmsS4 commented Apr 20, 2023

Hello i wrote an example for nextcloud + grafana using cdk8s in typescript.
This example includes:

  • nextcloud
  • mariadb
  • redis
  • traefik
  • cert-manager
  • certificate issuer
  • victoria metrics
  • grafana
    and these components of cdk8s and cdk8s+
  • Helm
  • Secret
  • Deployment
  • Container
  • EnvValue
  • Service
  • Ingress
  • PVC
  • ApiObject and JsonPatch
  • ConfigMap
  • InitContainer

I had to read lots of cdk8s's document and other examples to write this, so i think this example is not that bad :))

Signed-off-by: SmsS4 <[email protected]>
Signed-off-by: SmsS4 <[email protected]>
@SmsS4
Copy link
Author

SmsS4 commented Apr 25, 2023

I thinks it's fixed now
Could you please trigger build action? @iliapolo
Thanks.

@SmsS4 SmsS4 removed their assignment May 27, 2023
@vinayak-kukreja
Copy link

Hey @SmsS4 , apologies for the delay. Would you still like to work on this PR?

@vinayak-kukreja vinayak-kukreja added the response-requested Awaiting response from author label Aug 11, 2023
@SmsS4
Copy link
Author

SmsS4 commented Aug 12, 2023

No problem
Yes I still like to work on this PR
Thanks for reply

@github-actions github-actions bot removed the response-requested Awaiting response from author label Aug 12, 2023
@vinayak-kukreja
Copy link

Great, I will review the PR this week(asap). Thank you for opening a PR with us.

Copy link

@vinayak-kukreja vinayak-kukreja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is great!! :)

I just have a few NITs, let me know if you have any queries related to them.

typescript/nextcloud-with-grafana/README.md Show resolved Hide resolved
typescript/nextcloud-with-grafana/README.md Outdated Show resolved Hide resolved
typescript/nextcloud-with-grafana/main.ts Outdated Show resolved Hide resolved
typescript/nextcloud-with-grafana/README.md Outdated Show resolved Hide resolved
Signed-off-by: SmsS4 <[email protected]>
@SmsS4 SmsS4 force-pushed the main branch 2 times, most recently from 73126c3 to dfd0a66 Compare August 18, 2023 13:57
@vinayak-kukreja
Copy link

Hey @SmsS4, thank you for contributing. Changes LGTM.

I see build fails because some files are being changed with the new merge,

Error: Files were changed during build (see build log). If this was triggered from a fork, you will need to update your branch.

I believe integrating these changes on your branch and running the workflow would succeed. Let me know once you do that and I can approve it again. :)

Signed-off-by: SmsS4 <[email protected]>
@SmsS4
Copy link
Author

SmsS4 commented Aug 24, 2023

I think this should fix build problem @vinayak-kukreja

Signed-off-by: SmsS4 <[email protected]>
@SmsS4 SmsS4 force-pushed the main branch 2 times, most recently from 9ee982f to 88a6062 Compare August 26, 2023 10:28
SmsS4 and others added 2 commits August 26, 2023 14:02
@SmsS4
Copy link
Author

SmsS4 commented Aug 26, 2023

I'm 99% sure build won't fail anymore :)

@SmsS4
Copy link
Author

SmsS4 commented Aug 26, 2023

I'm 99% sure build won't fail anymore :)

I didn't see merge conflict :) I will resolve it tomorrow or later today

SmsS4 and others added 2 commits August 27, 2023 16:15
@SmsS4
Copy link
Author

SmsS4 commented Aug 27, 2023

@vinayak-kukreja I think everything is OK now

@SmsS4
Copy link
Author

SmsS4 commented Aug 28, 2023

Looks like build failed because of network issue
and conflict was for yaml libary version

@iliapolo
Copy link
Member

@SmsS4 Hi!

Apologies for the long back and forth here, but after some further internal discussion I'm afraid we cannot accept this PR as it currently stands. This examples repository is focused on showcasing cdk8s patterns and features, not specific tools or products.

Here is my suggestion for going forward.

  • Some parts of this PR can be generally helpful, for example your usage of PVC and JsonPatch. If you are willing, please scope this PR down to focus on specific features, and create a small dedicated examples for each of those.
  • For the parts of the code that create specific products (e.g mariadb, next cloud) I suggest you self publish those constructs similar to cdk8s-grafana. These packages will then appear on ConstructHub and have visibility for the larger CDK eco system.

Thanks!

@iliapolo iliapolo requested review from iliapolo and removed request for vinayak-kukreja August 29, 2023 09:19
@iliapolo iliapolo added the response-requested Awaiting response from author label Aug 29, 2023
@SmsS4
Copy link
Author

SmsS4 commented Aug 29, 2023

Thanks for response :)
OK I will add smaller examples

@SmsS4 SmsS4 closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
response-requested Awaiting response from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants