-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): add nextcloud #14
Conversation
Signed-off-by: SmsS4 <[email protected]>
Signed-off-by: SmsS4 <[email protected]>
I thinks it's fixed now |
Hey @SmsS4 , apologies for the delay. Would you still like to work on this PR? |
No problem |
Great, I will review the PR this week(asap). Thank you for opening a PR with us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this is great!! :)
I just have a few NITs, let me know if you have any queries related to them.
Signed-off-by: SmsS4 <[email protected]>
73126c3
to
dfd0a66
Compare
Hey @SmsS4, thank you for contributing. Changes LGTM. I see build fails because some files are being changed with the new merge,
I believe integrating these changes on your branch and running the workflow would succeed. Let me know once you do that and I can approve it again. :) |
Signed-off-by: SmsS4 <[email protected]>
I think this should fix build problem @vinayak-kukreja |
Signed-off-by: SmsS4 <[email protected]>
9ee982f
to
88a6062
Compare
Signed-off-by: SmsS4 <[email protected]>
Signed-off-by: SmsS4 <[email protected]>
I'm 99% sure build won't fail anymore :) |
I didn't see merge conflict :) I will resolve it tomorrow or later today |
Signed-off-by: SmsS4 <[email protected]>
Signed-off-by: SmsS4 <[email protected]>
@vinayak-kukreja I think everything is OK now |
Signed-off-by: SmsS4 <[email protected]>
Signed-off-by: SmsS4 <[email protected]>
Looks like build failed because of network issue |
@SmsS4 Hi! Apologies for the long back and forth here, but after some further internal discussion I'm afraid we cannot accept this PR as it currently stands. This examples repository is focused on showcasing cdk8s patterns and features, not specific tools or products. Here is my suggestion for going forward.
Thanks! |
Thanks for response :) |
Hello i wrote an example for nextcloud + grafana using cdk8s in typescript.
This example includes:
and these components of cdk8s and cdk8s+
I had to read lots of cdk8s's document and other examples to write this, so i think this example is not that bad :))