Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding #65 one of the things that flagged up was that no matter how long the
byte_match
the winner was not the longest match. This quick one liner addresses that issue. Confidence is sorted byconfidence
thenbyte_match
.Before, Alternate match 2 should be the winner:
Now it is! :
This will help in the future with really long matches if PureMagic adopts rules, for example using this
.xlsm
, Alternate Match 1 would be the better choice as the file matches the .vba aspect, however regular Excel wins as that has a slightly longer match, the Macro flavored version comes second. With a rules based system you could combine those together for a MEGA MATCH! ofb'PK\x03\x04\x14\x00\x06\x00xl/workbook.xmlxl/vbaProject.bin'
which should be unbeatable 😎: