e2e send-email test scenarios #1637
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
| sendEmailInvalidRecipients=incorrectrecp | ||
| sendEmailMessage=test case | ||
| [email protected] | ||
| sendEmailPassword=dummyPassword |
There was a problem hiding this comment.
we shouldn't store passwords in plaintext
There was a problem hiding this comment.
Password updated in Environment variables.
| private static boolean firstFileSinkTestFlag = true; | ||
|
|
||
| @Before(order = 1, value = "@FILE_SOURCE_TEST") | ||
| public static void setFileSourceAbsolutePath() { |
There was a problem hiding this comment.
are we using file source plugin in these tests? If not, please remove irrelevant code
There was a problem hiding this comment.
Yes, we are using file source plugin.
|
| And Wait till pipeline is in running state | ||
| And Open and capture logs | ||
| And Verify the pipeline status is "Succeeded" | ||
| #And Verify email sent message in logs (Implement this step once PLUGIN-1255 is fixed.) |
There was a problem hiding this comment.
I don't think it's expected that we would log a message when email is sent successfully.
A RuntimeException is thrown in the failure case - does this show up in the pipeline logs when there is an error in sending email? https://github.com/cdapio/hydrator-plugins/blob/develop/core-plugins/src/main/java/io/cdap/plugin/batch/action/EmailAction.java#L154
@rmstar @itsankit-google Please review.
CC: @sawantpritam