🐛 Properly reset task managers #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=====================================
Coverage 96.2% 96.2%
=====================================
Files 34 34
Lines 1751 1756 +5
Branches 214 214
=====================================
+ Hits 1685 1691 +6
+ Misses 66 65 -1
|
4 tasks
burgholzer
added a commit
that referenced
this pull request
Jan 5, 2024
) ## Description This was triggered by a clang-tidy warning that popped up in #348. This PR also adjusts the `TaskManager` interface to take a reference to a package instance instead of a unique pointer; making the interface more generic. This should unblock #348. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
force-pushed
the
reset-task-managers
branch
from
cd9df9b to
8f8e95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that
TaskManagerclass was only ever being reliably usable once due to its internal iterator and permutation not being reset in further invocations.Fixes #347
Checklist: