Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to new qiskit version. #327

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

pehamTom
Copy link
Member

@pehamTom pehamTom commented Nov 7, 2023

Description

The newest Qiskit release introduced some new deprecations and, unfortunately, also some internal deprecation warnings that now surface in our tests and must be ignored.
This PR adjusts MQT QCEC to these latest changes.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #327 (cd4e37d) into main (91ecd04) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #327   +/-   ##
=====================================
  Coverage   96.0%   96.0%           
=====================================
  Files         34      34           
  Lines       1739    1740    +1     
  Branches     212     212           
=====================================
+ Hits        1671    1672    +1     
  Misses        68      68           
Flag Coverage Δ *Carryforward flag
cpp 95.7% <ø> (ø) Carriedforward from 91ecd04
python 97.2% <100.0%> (+<0.1%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/mqt/qcec/parameterized.py 94.8% <100.0%> (+<0.1%) ⬆️

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. Just one small thing to fix so that CI runs through.
Could you also please add a proper PR description? 🙃

pyproject.toml Show resolved Hide resolved
@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Anything related to Python code labels Nov 7, 2023
@pehamTom pehamTom merged commit cd4e37d into main Nov 7, 2023
25 of 26 checks passed
@pehamTom pehamTom deleted the adapt-to-latest-qiskit-version branch November 7, 2023 11:11
@pehamTom pehamTom restored the adapt-to-latest-qiskit-version branch November 7, 2023 11:13
@pehamTom pehamTom deleted the adapt-to-latest-qiskit-version branch November 7, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants