Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add w state implementation #391

Merged
merged 17 commits into from
Aug 9, 2023
Merged

Add w state implementation #391

merged 17 commits into from
Aug 9, 2023

Conversation

tyi1025
Copy link
Contributor

@tyi1025 tyi1025 commented Aug 8, 2023 •
edited
Loading

Description

Implement WState from this mqt-bench script in light of the DD benchmarking in this PR.

@tyi1025 tyi1025 added the enhancement New feature or request label Aug 8, 2023
@tyi1025 tyi1025 self-assigned this Aug 8, 2023
@tyi1025 tyi1025 changed the title Add w state implementation [Draft] Add w state implementation Aug 8, 2023
@tyi1025 tyi1025 marked this pull request as draft August 8, 2023 23:23
@tyi1025 tyi1025 changed the title [Draft] Add w state implementation Add w state implementation Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #391 (4d3eb18) into main (a2b040e) will increase coverage by 0.0%.
Report is 1 commits behind head on main.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #391   +/-   ##
=====================================
  Coverage   89.1%   89.2%           
=====================================
  Files         97      98    +1     
  Lines      11713   11726   +13     
  Branches    2098    2101    +3     
=====================================
+ Hits       10445   10460   +15     
+ Misses      1268    1266    -2
Files Changed Coverage Δ
src/algorithms/WState.cpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

burgholzer
burgholzer requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments since I had some time.
Also, please make sure to add respective tests as for the other algorithms.

src/algorithms/WState.cpp Outdated Show resolved Hide resolved
src/algorithms/WState.cpp Outdated Show resolved Hide resolved
src/algorithms/WState.cpp Outdated Show resolved Hide resolved
src/algorithms/WState.cpp Outdated Show resolved Hide resolved
src/algorithms/WState.cpp Outdated Show resolved Hide resolved
src/algorithms/WState.cpp Outdated Show resolved Hide resolved
src/algorithms/WState.cpp Outdated Show resolved Hide resolved
burgholzer
burgholzer requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some further comments 🙂

test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
burgholzer
burgholzer requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some finishing touches 🙂

src/algorithms/WState.cpp Outdated Show resolved Hide resolved
test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
test/algorithms/test_wstate.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@tyi1025 tyi1025 added c++ Anything related to C++ code feature New feature or request and removed enhancement New feature or request labels Aug 9, 2023
@tyi1025 tyi1025 marked this pull request as ready for review August 9, 2023 10:25
@tyi1025 tyi1025 requested a review from burgholzer August 9, 2023 10:26
@burgholzer burgholzer added this to the MQT Core milestone Aug 9, 2023
burgholzer
burgholzer approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Turned out well 👍🏼

@burgholzer burgholzer merged commit da83c0b into main Aug 9, 2023
@burgholzer burgholzer deleted the add-w-state branch August 9, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgholzer burgholzer burgholzer approved these changes

Assignees

@tyi1025 tyi1025

Labels
c++ Anything related to C++ code feature New feature or request
Projects
MQT
Status: Done
MQT Core
Status: Done
Milestone
MQT Core
Development

Successfully merging this pull request may close these issues.
2 participants
@tyi1025 @burgholzer