Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize plugin on Signal tycon #17

Closed
wants to merge 1 commit into from

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Jan 27, 2024

clash-protocols must use CSignal, not Signal, for unidirectional signals in Circuits.

See clash-lang/clash-protocols#59.

Clash must use `CSignal`, not `Signal`, for unidirectional signals in
`Circuit`s.

See clash-lang/clash-protocols#59.
@bgamari bgamari marked this pull request as draft January 27, 2024 19:16
@bgamari
Copy link
Contributor Author

bgamari commented Jan 27, 2024

Moved into draft state as I would like to hear @martijnbastiaan's opinion on this.

@bgamari
Copy link
Contributor Author

bgamari commented Jan 27, 2024

Ahh, it appears that ad3c557 and the preceding refactorings may have eliminated the need for this.

@martijnbastiaan
Copy link
Collaborator

My understanding is that this indeed handled correctly by the plugin, as of @jonfowler's PR. What's confusing here is that you can write Signal at any place you can write Fwd - even if the Fwd doesn't resolve to a Signal. That is to say, the example you post in clash-lang/clash-protocols#59 should probably switch to Fwd to make it less confusing. (And.. we should probably change clash-protocol's CSignal :-))

I wouldn't mind a second opinion from @jonfowler.

@martijnbastiaan
Copy link
Collaborator

I believe we've resolved the confusion that was part of this PR by now. @bgamari feel free to re-open if that's not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants