Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an option for thread highlighting to override hiding #3284

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Filtering/Filter.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ Filter =
unless hl and filter.hl in hl
(hl or= []).push filter.hl
top or= filter.top
if filter.hl and Conf['Always Show Highlighted Threads']
hide = false
hideable = false
if filter.noti
noti = true
if hide
Expand All @@ -164,6 +167,7 @@ Filter =
ThreadHiding.hide @thread, stub
else
if hl
@thread.isHighlighted = true
@highlights = hl
$.addClass @nodes.root, hl...
if noti and Unread.posts and (@ID > Unread.lastReadPost) and not QuoteYou.isYou(@)
Expand Down
2 changes: 1 addition & 1 deletion src/Filtering/ThreadHiding.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ ThreadHiding =
ThreadHiding.saveHiddenState thread

hide: (thread, makeStub=Conf['Stubs']) ->
return if thread.isHidden
return if thread.isHidden or (thread.isHighlighted and Conf['Always Show Highlighted Threads'])
threadRoot = thread.nodes.root
thread.isHidden = true
Index.updateHideLabel()
Expand Down
1 change: 1 addition & 0 deletions src/classes/Thread.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class Thread
@posts = new SimpleDict()
@isDead = false
@isHidden = false
@isHighlighted = false
@isSticky = false
@isClosed = false
@isArchived = false
Expand Down
4 changes: 4 additions & 0 deletions src/config/Config.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,10 @@ Config =
true
'Add buttons to hide single replies.'
]
'Always Show Highlighted Threads': [
false
'Make thread highlighting override hiding.'
]
'Stubs': [
true
'Show stubs of hidden threads / replies.'
Expand Down