Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/syncCommunicator #1741

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix/syncCommunicator #1741

merged 3 commits into from
Jul 23, 2024

Conversation

RodriSanchez1
Copy link
Collaborator

@RodriSanchez1 RodriSanchez1 commented Jul 17, 2024 •
edited
Loading

On this PR:

  • Return the local communicator on the reconciliation if it doesn´t have a timestamp.
  • Update the remote communicator if the activeCommunicator is newer than the remote
  • Change the active communicator after sync just if the active communicator is default.

@RodriSanchez1 RodriSanchez1 requested a review from tomivm July 23, 2024 02:36
@RodriSanchez1 RodriSanchez1 merged commit c85429f into cboard-org:master Jul 23, 2024
5 checks passed
@RodriSanchez1 RodriSanchez1 deleted the fix/syncCommunicator branch July 23, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivm tomivm tomivm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RodriSanchez1 @tomivm