Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pdf navbar export #1649

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Fix/pdf navbar export #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc72451
Revert "Fix the order of params on pdfExportAdapter"
RodriSanchez1 Dec 26, 2023
8d76945
Add medium font size for pdf export in PrintBoardButton
RodriSanchez1 Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Settings/Export/Export.helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,9 +890,9 @@ export async function cboardExportAdapter(allBoards = [], board) {

export async function pdfExportAdapter(
boards = [],
labelFontSize,
intl,
picsee = false,
labelFontSize
picsee = false
) {
const font = definePDFfont(intl);
const docDefinition = {
Expand Down
3 changes: 2 additions & 1 deletion src/components/UI/PrintBoardButton/PrintBoardButton.container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import PrintBoardButton from './PrintBoardButton.component';
import PrintBoardDialog from './PrintBoardDialog.component';
import messages from './PrintBoardButton.messages';
import { showNotification } from '../../Notifications/Notifications.actions';
import { MEDIUM_FONT_SIZE } from '../../Settings/Export/Export.constants';

class PrintBoardButtonContainer extends React.Component {
constructor(props) {
Expand Down Expand Up @@ -37,7 +38,7 @@ class PrintBoardButtonContainer extends React.Component {
);

const { pdfExportAdapter } = await this.exportHelpers;
pdfExportAdapter([currentBoard], intl).then(() => {
pdfExportAdapter([currentBoard], MEDIUM_FONT_SIZE, intl).then(() => {
this.setState({ loading: false });
showNotification(intl.formatMessage(messages.boardDownloaded));
});
Expand Down