-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump/nodejs v18 #1595
Bump/nodejs v18 #1595
Conversation
This reverts commit 0e7cd87.
@RodriSanchez1 Shouldn't we remove the |
@RodriSanchez1 Just installed dependencies and run and got the following error: |
No, we still use it. But an update to
Do you change your node version to v18.18.1 before build? On my pc is building well. |
"start": "react-scripts start", | ||
"build": "react-scripts build && sw-precache --config=sw-precache-config.js", | ||
"start": "craco start", | ||
"build": "craco build && sw-precache --config=sw-precache-config.js", | ||
"build-cordova-debug": "react-app-rewired build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is react-app-rewired
needed? can you use craco instead? (i'm not sure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can remove it. I will do that in other PR
On this PR:
v18.18.1
. The new version was pinned on docker file,.nvmrc
and CI config.NOTE: We are currently react-rewire (similiar than CRACO) but is not maintened anymore. Needs to migrate.
--maxWorkers=50%
for--runInBand
on CI config. This change was made because the Unit Test were hanging with no output response. Also increment the run speed of the test.Import.constants.js
andExport.helpers.js
WelcomeScreen.css
openDb
import onarasaac.ts
yarn.lock
file