Small fix

cboard-org · Dec 11, 2023 · 30e5ef7 · 30e5ef7
1 parent b87121f
commit 30e5ef7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/components/Board/TileEditor/TileEditor.component.js b/src/components/Board/TileEditor/TileEditor.component.js
@@ -574,7 +574,7 @@ export class TileEditor extends Component {
                     <div className="TileEditor__input-image">
                       <InputImage
                         onChange={this.handleInputImageChange}
-                        setIsImageLoading={this.handleLoadingStateChange}
+                        setIsLoadingImage={this.handleLoadingStateChange}
                       />
                     </div>
                   </div>

diff --git a/src/components/UI/InputImage/InputImage.component.js b/src/components/UI/InputImage/InputImage.component.js
@@ -37,11 +37,10 @@ class InputImage extends Component {
     /**
      * Set image loading state
      */
-    setIsImageLoading: PropTypes.func.isRequired
+    setIsLoadingImage: PropTypes.func.isRequired
   };
 
   async resizeImage(file, imageName = null) {
-    const { setIsImageLoading } = this.props;
     //if you cancel the image uploaded, the event is dispached and the file is null
     try {
       const { onChange } = this.props;
@@ -52,17 +51,16 @@ class InputImage extends Component {
     } catch (err) {
       console.error(err);
     }
-    setIsImageLoading(false);
   }
 
   onClick = async () => {
-    const { setIsImageLoading } = this.props;
-    setIsImageLoading(true);
+    const { setIsLoadingImage } = this.props;
     try {
       const imageURL = await window.cordova.plugins.safMediastore.selectFile();
       const imageName = await window.cordova.plugins.safMediastore.getFileName(
         imageURL
       );
+      setIsLoadingImage(true);
       const file = await new Promise((resolve, reject) => {
         window.resolveLocalFileSystemURL(
           imageURL,
@@ -90,16 +88,18 @@ class InputImage extends Component {
     } catch (err) {
       console.error(err);
     }
+    setIsLoadingImage(false);
   };
 
   handleChange = async event => {
-    const { setIsImageLoading } = this.props;
-    setIsImageLoading(true);
+    const { setIsLoadingImage } = this.props;
+    setIsLoadingImage(true);
     const file = event.target.files[0];
     if (file) {
       //if you cancel the image uploaded, the event is dispached and the file is null
       await this.resizeImage(file);
     }
+    setIsLoadingImage(false);
   };
   render() {
     const { intl } = this.props;

diff --git a/src/components/UI/InputImage/InputImage.test.js b/src/components/UI/InputImage/InputImage.test.js
@@ -17,19 +17,19 @@ jest.mock('./InputImage.messages', () => {
 describe('InputImage tests', () => {
   test('default render ', () => {
     const onChange = jest.fn();
-    const setIsImageLoading = jest.fn();
+    const setIsLoadingImage = jest.fn();
     const wrapper = mount(
       <InputImage
         disabled={false}
         onChange={onChange}
-        setIsImageLoading={setIsImageLoading}
+        setIsLoadingImage={setIsLoadingImage}
       />
     );
     expect(wrapper).toMatchSnapshot();
   });
   test('on buttton click', () => {
     const onChange = jest.fn();
-    const setIsImageLoading = jest.fn();
+    const setIsLoadingImage = jest.fn();
     const event = {
       target: {
         files: [new File(['foo'], 'foo.txt')]
@@ -40,7 +40,7 @@ describe('InputImage tests', () => {
         user={{ email: 'test' }}
         disabled={false}
         onChange={onChange}
-        setIsImageLoading={setIsImageLoading}
+        setIsLoadingImage={setIsLoadingImage}
       />
     );
     wrapper.find('input').prop('onChange')(event);