Test/user with async await #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I mean don´t execute sendEmail it's no so simple. Because we need to test all the rest of Code. I was seeing a way to do it but I can't yet. |
|
the problem of slow feedback on test is solved in PR #158 |
mock nodemailer for dont sent emails
sylvansson
reviewed
Apr 11, 2021
martinbedouret
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User test without done() callback.
I don't use generateEmail() because the mocha User o Admin User is deleted after every test.
with this, all the test are isolated and leaves no trace in DB.
What do you think about this @sylvansson ?
@martinbedouret we should stub the email server process to remove the increment of the timeout on the test. like Simon says in #132 PR
https://sinonjs.org/releases/latest/stubs/