Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin defects, exception class logic & add visibility icons #116

Merged
merged 13 commits into from
Sep 21, 2024

Conversation

thelooter
Copy link
Collaborator

Fixes Plugin Defects by only optionally styling Icons

@thelooter thelooter self-assigned this Sep 19, 2024
@thelooter thelooter marked this pull request as draft September 19, 2024 19:32
@thelooter thelooter marked this pull request as ready for review September 19, 2024 19:42
@thelooter
Copy link
Collaborator Author

This also restores default visibility icons for now

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also restores default visibility icons for now

I think we're missing a layer of visibility icons.

Default:

image

Catppuccin Icons:

image

@sgoudham sgoudham changed the title refactor(java): refactor Java file icons to be optionally styled fix: plugin defects, exception class detection & visibility icons Sep 21, 2024
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy with this now, thank you for your work again @thelooter

image

@sgoudham sgoudham changed the title fix: plugin defects, exception class detection & visibility icons fix: plugin defects, exception class logic & add visibility icons Sep 21, 2024
@sgoudham sgoudham merged commit 7e36666 into catppuccin:main Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include visibility icons Configuration of Catppuccin Icons 1.6.2 has 2 defects
2 participants