-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend Configuration IIb] Add backend collection tools #570
[Backend Configuration IIb] Add backend collection tools #570
Conversation
for more information, see https://pre-commit.ci
…kend_add_backend_configuration_tool
…kend_add_backend_configuration_tool
…kend_add_backend_configuration_tool
@h-mayorquin Ready for review now, should be an easy one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort PR, so mostly discussion. Now that we are getting to the end of this chain of PRs I have some usability questions but I think this will be better in person. I have some small requests but they are very small details and discussion points. Approving now, up to you if you want to change some of them.
Thanks for all the hard work.
...est_backend_and_dataset_configuration/test_helpers/test_get_default_backend_configuration.py
Show resolved
Hide resolved
...est_backend_and_dataset_configuration/test_helpers/test_get_default_backend_configuration.py
Outdated
Show resolved
Hide resolved
OK I'll change the wording to 'expected' and merge, leaving the rest of the items for follow-up discussion and action |
@CodyCBakerPhD |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
+ Coverage 91.62% 91.65% +0.02%
==========================================
Files 107 107
Lines 5648 5653 +5
==========================================
+ Hits 5175 5181 +6
+ Misses 473 472 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Expands on #569
This takes the datasets found from the previous dataset collection operation, which is then assembled into a single backend representation of the file contents, and will then be passed back to the user for confirmation before any final configuration of the datasets is performed