Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend Configuration IIb] Add backend collection tools #570

Merged
merged 20 commits into from
Nov 28, 2023

Conversation

CodyCBakerPhD
Copy link
Member

Expands on #569

This takes the datasets found from the previous dataset collection operation, which is then assembled into a single backend representation of the file contents, and will then be passed back to the user for confirmation before any final configuration of the datasets is performed

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 18, 2023
Base automatically changed from new_backend_default_dataset_configuration to main November 22, 2023 20:05
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review November 25, 2023 21:05
@CodyCBakerPhD
Copy link
Member Author

@h-mayorquin Ready for review now, should be an easy one

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort PR, so mostly discussion. Now that we are getting to the end of this chain of PRs I have some usability questions but I think this will be better in person. I have some small requests but they are very small details and discussion points. Approving now, up to you if you want to change some of them.

Thanks for all the hard work.

@CodyCBakerPhD
Copy link
Member Author

Now that we are getting to the end of this chain of PRs I have some usability questions but I think this will be better in person. I have some small requests but they are very small details and discussion points.

OK I'll change the wording to 'expected' and merge, leaving the rest of the items for follow-up discussion and action

@h-mayorquin
Copy link
Collaborator

@CodyCBakerPhD
Thanks for engaging in discussion. Feel free to merge.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #570 (df5a1a4) into main (1a7ba58) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   91.62%   91.65%   +0.02%     
==========================================
  Files         107      107              
  Lines        5648     5653       +5     
==========================================
+ Hits         5175     5181       +6     
+ Misses        473      472       -1     
Flag Coverage Δ
unittests 91.65% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/neuroconv/tools/nwb_helpers/__init__.py 100.00% <100.00%> (ø)
...roconv/tools/nwb_helpers/_dataset_configuration.py 92.75% <100.00%> (+2.12%) ⬆️
...euroconv/tools/nwb_helpers/_models/_base_models.py 96.74% <ø> (ø)

@CodyCBakerPhD CodyCBakerPhD merged commit a4b157f into main Nov 28, 2023
36 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the new_backend_add_backend_configuration_tool branch November 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants