-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI, port): Port hiding traits/mutations from DDA #5754
Conversation
Co-Authored-By: Fris0uman <[email protected]>
Oops, apparently we have two switches
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a windows user for testing but this should be fine, it builds off the previous PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Co-Authored-By
in the commit message.Purpose of change
Much like with hiding clothing, hiding traits and mutations is a much-desired feature for various reasons. Considering how much it's desired and how simple it was to port, I see no reason not to bring it in.
Describe the solution
Ports CleverRaven/Cataclysm-DDA#52058 from DDA.
Describe alternatives you've considered
Testing
It builds, it works (on my machine anyway)
Additional context
2/3 of the hiding visuals ports that RoyalFox threw at us done. Next up, Bionics! (For whoever ends up taking that one on)
Don't worry Chaos, this time I made sure the keybind was BN-ified the first time ;P