-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove z-level restriction for zone activities. #5234
base: main
Are you sure you want to change the base?
Conversation
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we remove commented out code?
will do |
I really want to see this PR happen, when it needs testing I might be able to open it up (depending on when im upgrading to linux which is very very soon.) |
the changes look nice, will review after i get home |
After testing it a fair bit more the pathfinding is extremely random on where and why it gets stuck but it's always because it can't navigate stairs. It just sometimes does and sometimes doesn't. Maybe @KheirFerrum knows why the pathfinding breaks. |
No bloody clue. I would also remind the OP that z-level processing is optional, so make sure your checks reflect that. If z-levels are turned off it likely won't matter what you try to feed the function, it will simply assume the current z-level. |
Z-Levels are mandatory behavior now after one of Zlor's PR's. 3D vision however is optional I'm not sure how this affects the PR but I had 3D vision on when I was failing to path find. |
I have a feeling path finding has some max route length that maybe causing the cancellation. Will see if I can make more changes. |
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Purpose of change
Note: : had to resubmit PR due to issues with my fork, should be good now.
Update the code to ignore z-level differences when working with zones. This should make it easier to setup loot zones across the z-levels for easier loot managements, i.e. basements, roofs, apartments and LMOE. It was a bit annoying to carry the loot up/down stairs.
Describe the solution
Solution is to remove all checks for z-level, both in the GUI and code that interacts with zones.
Describe alternatives you've considered
None. I think zones are currently the best way to manage loot, and just need to tweak them to work properly.
Testing
Additional context
This is half-tested. I compiled the code, did some zone setup in my LMOE bunker and asked my main char to sort out the loot. Seem(s) like it worked. However more testing will likely be required. Volunteers appreciated.