-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add secured lockers and computer action to open them #4703
base: main
Are you sure you want to change the base?
Conversation
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
|
There is a typo on Mainentance, its Maintenance. Since a lot of our community isn't native english speakers if you need help on the grammar or spelling I'll look at it when it's ready for review. |
you can add some regular small cardboard boxes and put them in there. Maybe place some duct tape at a table near of it. (and a table itself), sometimes they try to fix broken parcels. |
are you sure that changes belong here? |
cant seem to revert changes on web ui |
@Ali-Anomma You're going to need to create a new branch and migrate the changes from this PR manually since you've targeted your upload branch and made new pulls afterward. Cleaning this pull up is going to be incredibly difficult but making a new one will be fast if you copy paste your changes to a branch. |
Purpose of change
Subways need more content, and parcel lockers has beengetting popular on subways recently.
Also who doesnt want to be a porch pirate amirite?
Describe the solution
Modified computers "open doors" function to make lockers open instead (for some reason it only worked on terrains so this locker is a terrain now)
Describe alternatives you've considered
Making a cargo holding area that can be accesible with locked door.
Testing
MSYS2 with Windows 10
injected following code on the bank map computer:
"computers": { "6": { "name": "Escargot Express Parcel Locker Access", "security": 1, "options": [ { "name": "Mainentance mode: Open All Lockers", "action": "open_locker" } ], "failures": [ { "action": "alarm" } ] }
Additional context
Checklist
Add secured lockers and make them pickable
Add computer action to open lockers remotely
Put secured lockers in various places such as military buildings to store valuable items
Using handful of lockers and one computer, create parcel lockers
Put parcel lockers on places like subway stations, outside of post offices, malls etc.
Add loot pool for parcel lockers, those loot should be both transportable via cargo and valuable to player. So jewelries, clothes or entertainment stuff will only work as filler; real loot will be SD cards, drugs, "criminal" CBM's, lab chemicals like ampoulle, lab books, small equpment such as military grade NV glasses etc.
Somehow add a very tiny chance to spawn a live bomb on locker