feat(port): attunements infrastructure #3135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this should enable the attunement system in Magiclysm, although effect_on_condition and other support code will be needed to port much of the actual Maglclysm attunement content over
dammit
scarf005
changed the title
scarf005
changed the title
|
Are you still working on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Port over attunements infrastructure"
Purpose of change
I think this should enable the attunement system in Magiclysm, although effect_on_condition and other support code will be needed to port much of the actual Maglclysm attunement content over.
Describe the solution
This just adds some iexamine functionality and support code.
Describe alternatives you've considered
Not doing it
Testing
It seems to work when I examine the altar (which I'm preparing to add in a separate PR after adding effect_on_condition infrastructure as well)
Additional context
None