revert: Obsolete useless hub01 basement

[scarf005]

Purpose of change

• does not interfere with codebase since it's pure JSON changes
• we could port over more hub01 contents from DDA
• it could be done as a single revert commit

Describe the solution

• fixes Rollback removed hub01 basement and NPCs. #2257
• reverts Obsolete useless hub01 basement #1457

Describe alternatives you've considered

keep the status as-is. however, we could port more hub01 contents to fill the feature parity between DDA.

Testing

reverted then spawned hub01 on overmap. played for a while. quest was quite fun. maybe someone should port more DDA hub01 contents.

[Firestorm01X2]

Rationale from issue to restore hub01 basement.

#2257

rationale

* does not interfere with codebase since it's pure JSON changes

* we could port over more hub01 contents from DDA

* it could be done as a single revert commit

[scarf005]

...oh, yeah. used wrong section.

[Firestorm01X2]

I guess we need to ask @Coolthulhu

[Zireael07]

we could port over more hub01 contents from DDA

"We could" I guess could be rejected as a rationale unless someone demonstrates they want to port more, though? As it stands, it doesn't do much

[scarf005]

there were some serious request to port over hub01 contents from korean community so i was investigating. haven't checked with dda's hub prs, however.

[Zireael07]

there were some serious request to port over hub01 contents from korean community

Oh, in that case I retract my objection since it seems there's genuine interest <3

[chaosvolt]

I think it's fine either way I suppose. The main reason to remove it is if it actually impacts performance, and I think by now performance should be fairly a bit better such that we can afford to keep it.

The other reason to remove it is the whole "you currently can't access it unless you're playing the game wrong" thing, but this seems like a thing that will be negated by any future plans if someone gets around to implementing a valid reason to access the location. Being given permission to visit them in the future to assist with something on-site, or tasked with breaking in by another faction antagonistic to the faction, for examples. While that does hinge on someone going and actually doing it, they can't exactly begin to without the location also existing to be fleshed out.

@Zlorthishen also brought up in DMs the idea of fleshing out the refugee center and giving it a working underground layer, if the performance impact of it proves to be tolerable. This however is likely a "if it gets implemented it'll likely be directly in service to actually using it" thing instead, whereas here we already have the location but just need to rig it to factor into gameplay/story.

[Coolthulhu]

I'm fine with un-removing if it is going to become playable, but the PR should only be merged along with the PR that makes it playable.
As in, if you need the removed content for something, base your hub01-but-playable branch on this branch, then link to this PR and say something like "includes this PR".

[scarf005]

@NobleJake, could you help me find which PR adds access to hub 01 basement?

[NobleJake]

Sorry for late reply. First of all, I am looking for pr related to hub 01 basement on cdda github, and additionally posted a question about quest related with hub 01 basement on reddit. If there are results, I will report them.

[NobleJake]

@scarf005
I posted a question on Reddit asking if there was a quest to Hub 01.
The answer came, 'There is no way to go yet, and it is just there.' In other words, there was no direct quest leading to the basement. I feel really sorry for bothering you. If adding Hub01's basement is difficult, I think it's better to leave it in my personal mod unless additional related story comes out.

[scarf005]

@NobleJake no worries. we could wait until related related DDA PR, but if you could create relevent quest that leads to hub01 basement, we're more than welcome for contribution!

[NobleJake]

https://www.reddit.com/r/cataclysmdda/comments/123cm63/what_is_hub_01_basement_for/?utm_source=share&utm_medium=android_app&utm_name=androidcss&utm_term=1&utm_content=share_button

There is a possibility that the underground hub agents will eventually release their hostile state someday, so I think it would be good to watch for a while.

[Zireael07]

A PR was just made to CDDA CleverRaven/Cataclysm-DDA#64712 to add an achievement for hub01, so it's not totally useless now ;)

[scarf005]

still, we'll have to wait until basement.