Don't encode ',null' unnecessarily

cashapp · Aug 26, 2024 · 6e5fa9c · 6e5fa9c
1 parent 869ad50
commit 6e5fa9c
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/redwood-treehouse-guest/src/jsMain/kotlin/app/cash/redwood/treehouse/ProtocolBridgeJs.kt b/redwood-treehouse-guest/src/jsMain/kotlin/app/cash/redwood/treehouse/ProtocolBridgeJs.kt
@@ -143,11 +143,15 @@ internal class FastGuestProtocolAdapter(
 
     value.forEach { element ->
       val (tag, serializer) = widgetSystemFactory.modifierTagAndSerializationStrategy(element)
-      val value = when {
-        serializer == null -> null
-        else -> json.encodeToDynamic(serializer, element)
+      when {
+        serializer != null -> {
+          val value = json.encodeToDynamic(serializer, element)
+          elements.push(js("""[tag,value]"""))
+        }
+        else -> {
+          elements.push(js("""[tag]"""))
+        }
       }
-      elements.push(js("""[tag,value]"""))
     }
 
     val id = id