Fail if invalid spdx is passed to allow #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Mar 29, 2024
Comment on lines
+253
to
+255
| requireNotNull(SpdxLicenses.embedded.findByIdentifier(spdxId)) { | ||
| "$name is not a valid SPDX id." | ||
| } |
There was a problem hiding this comment.
It seems like this could have been put in the old allow before adding to the set to accomplish the same thing. Is there another advantage of all the other changes that I'm missing? Is it secretly working towards #313?
There was a problem hiding this comment.
There was a problem hiding this comment.
I would prefer them separate, but we can leave the infrastructure in place here.
There was a problem hiding this comment.
BTW I don't plan to implement #313 today and it needs some design first, in case you want to publish another release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223