Add support for Kotlin Android plugin #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw.android.2024-10-18
branch
from
d74454e to
087517e
Compare
JakeWharton
commented
Oct 18, 2024
| @@ -65,8 +66,7 @@ class BurstGradlePluginTest { | |||
|
|
|||
| val taskName = ":lib:$testTaskName" | |||
| val result = createRunner(projectDir, "clean", taskName).build() | |||
| assertThat(SUCCESS_OUTCOMES) | |||
| .contains(result.task(taskName)!!.outcome) | |||
| assertThat(result.task(taskName)!!.outcome).isIn(*SUCCESS_OUTCOMES) | |||
There was a problem hiding this comment.
JakeWharton
commented
Oct 18, 2024
| @@ -20,4 +23,15 @@ allprojects { | |||
| mavenCentral() | |||
| google() | |||
| } | |||
|
|
|||
| tasks.withType(JavaCompile::class.java).configureEach { | |||
| sourceCompatibility = "1.8" | |||
There was a problem hiding this comment.
None of these projects built on my machine without this. My default JDK is 23, but Kotlin doesn't know about that version so it drops down to target 22 and then complains Kotlin and Java targets don't match.
oldergod
approved these changes
Oct 18, 2024
Comment on lines
+5
to
+18
| @Burst | ||
| class CoffeeTest( | ||
| private val espresso: Espresso, | ||
| ) { | ||
| @BeforeTest | ||
| fun setUp() { | ||
| println("set up $espresso") | ||
| } | ||
|
|
||
| @Test | ||
| fun test(dairy: Dairy) { | ||
| println("running $espresso $dairy") | ||
| } | ||
| } |
There was a problem hiding this comment.
Are those tests just validating the compilation step ? I don't think we're reading the printed lines?
There was a problem hiding this comment.
Correct. We'd need an emulator to run the instrumented tests and the JVM ones are identical to the existing JVM tests.
I can add it in a follow-up if we want them.
squarejesse
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27