Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repository): add repository for machine related functions #589

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat(repository): add repository for machine related functions #589

merged 1 commit into from
Sep 27, 2024

Conversation

renan061
Copy link
Contributor

No description provided.

@renan061 renan061 added this to the 2.0.0 milestone Aug 30, 2024
@renan061 renan061 self-assigned this Aug 30, 2024
@renan061 renan061 changed the base branch from main to feature/machines-map August 30, 2024 21:45
@renan061 renan061 changed the title Feature/advancer repository feat(repository): add repository for machine related functions Aug 30, 2024
@marcelstanley marcelstanley requested a review from a team September 2, 2024 17:24
torives
torives reviewed Sep 3, 2024
View reviewed changes
internal/repository/machine.go Outdated Show resolved Hide resolved
internal/repository/machine.go Show resolved Hide resolved
fmoura
fmoura previously requested changes Sep 4, 2024
View reviewed changes
internal/repository/machine.go Show resolved Hide resolved
marcelstanley
marcelstanley reviewed Sep 6, 2024
View reviewed changes
internal/repository/machine.go Outdated Show resolved Hide resolved
internal/repository/machine.go Outdated Show resolved Hide resolved
internal/repository/machine.go Outdated Show resolved Hide resolved
internal/repository/machine.go Outdated Show resolved Hide resolved
internal/repository/machine_test.go Show resolved Hide resolved
internal/repository/machine.go Outdated Show resolved Hide resolved
internal/repository/machine.go Show resolved Hide resolved
@vfusco vfusco force-pushed the feature/machines-map branch from 31c55f0 to cf978c5 Compare September 9, 2024 15:09
@vfusco vfusco force-pushed the feature/advancer-repository branch from 026621d to 40b2fd7 Compare September 9, 2024 15:21
Base automatically changed from feature/machines-map to next/2.0 September 9, 2024 15:22
@mpolitzer mpolitzer force-pushed the feature/advancer-repository branch 4 times, most recently from a9a13b1 to 8dd2a58 Compare September 25, 2024 20:08
@mpolitzer mpolitzer force-pushed the feature/advancer-repository branch from 8dd2a58 to f63c12d Compare September 25, 2024 20:17
vfusco
vfusco approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@vfusco vfusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging it as is. We will improve it later.

@vfusco vfusco dismissed fmoura’s stale review September 27, 2024 14:30

stale review

@vfusco vfusco merged commit f63c12d into next/2.0 Sep 27, 2024
7 checks passed
@vfusco vfusco deleted the feature/advancer-repository branch September 27, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelstanley marcelstanley marcelstanley left review comments

@torives torives torives left review comments

@fmoura fmoura fmoura left review comments

@vfusco vfusco vfusco approved these changes

Assignees

@renan061 renan061

Labels
None yet
Projects
Node Unit
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@renan061 @fmoura @vfusco @torives @marcelstanley