Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(offchain): implement the broker-listener for the authority-claimer #58

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat(offchain): implement the broker-listener for the authority-claimer #58

merged 1 commit into from
Oct 2, 2023

Conversation

renan061
Copy link
Contributor

@renan061 renan061 commented Aug 23, 2023 •
edited by marcelstanley
Loading

Closes #38

@renan061 renan061 self-assigned this Aug 23, 2023
@renan061 renan061 linked an issue Aug 23, 2023 that may be closed by this pull request
Implement broker for authority-claimer #38
Closed
2 tasks
@renan061 renan061 force-pushed the feature/authority-claimer-broker-listener branch 2 times, most recently from 089768b to 08b9274 Compare August 23, 2023 04:12
@renan061 renan061 requested a review from a team August 23, 2023 04:22
@renan061 renan061 marked this pull request as ready for review August 23, 2023 04:22
@renan061 renan061 force-pushed the feature/authority-claimer-broker-listener branch from 08b9274 to 79c4184 Compare August 23, 2023 04:24
@gligneul gligneul changed the base branch from next to main August 24, 2023 13:29
@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from 79c4184 to 85b9476 Compare September 4, 2023 17:31
@marcelstanley marcelstanley added the no changelog PRs that don't require changes in changelog label Sep 4, 2023
marcelstanley

This comment was marked as outdated.

Sign in to view

torives
torives reviewed Sep 5, 2023
View reviewed changes
offchain/authority-claimer/src/claimer.rs Outdated Show resolved Hide resolved
offchain/rollups-events/src/broker/mod.rs Outdated Show resolved Hide resolved
@gligneul gligneul self-requested a review September 8, 2023 13:29
@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from 85b9476 to 92bf1ed Compare September 8, 2023 17:43
gligneul
gligneul suggested changes Sep 8, 2023
View reviewed changes
offchain/authority-claimer/src/listener.rs Outdated Show resolved Hide resolved
offchain/authority-claimer/src/lib.rs Outdated Show resolved Hide resolved
@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch 2 times, most recently from 7d9e13b to ca33b8b Compare September 14, 2023 22:08
@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from ca33b8b to e8609d8 Compare September 25, 2023 17:00
@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from e8609d8 to 226c386 Compare September 25, 2023 17:20
@marcelstanley
Copy link
Contributor

@renan061, I'd appreciate if you could take a look at the changes I made as well.

@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from 226c386 to ec200ef Compare September 25, 2023 17:54
gligneul
gligneul suggested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just minor details.

offchain/authority-claimer/src/claimer.rs Outdated Show resolved Hide resolved
offchain/authority-claimer/src/listener.rs Outdated Show resolved Hide resolved
offchain/authority-claimer/src/mock.rs Outdated Show resolved Hide resolved
@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from 8d8320f to 14d94e9 Compare September 26, 2023 18:20
@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from 14d94e9 to 1138ead Compare September 26, 2023 18:22
gligneul
gligneul previously approved these changes Sep 26, 2023
View reviewed changes
@gligneul
Copy link
Contributor

@renan061 please take a look as well.

@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from 1138ead to 51a728d Compare September 27, 2023 21:17
@marcelstanley marcelstanley force-pushed the feature/authority-claimer-broker-listener branch from 51a728d to e7bc5a0 Compare September 29, 2023 17:05
@marcelstanley marcelstanley changed the base branch from main to next September 29, 2023 17:07
@marcelstanley marcelstanley dismissed gligneul’s stale review September 29, 2023 17:07

The base branch was changed.

@marcelstanley
Copy link
Contributor

Rebased the PR on top of next.

@gligneul @renan061 FYI

@marcelstanley marcelstanley self-requested a review September 29, 2023 18:23
@marcelstanley marcelstanley changed the base branch from next to main September 29, 2023 18:35
@marcelstanley marcelstanley changed the base branch from main to next September 29, 2023 18:38
renan061
renan061 commented Oct 2, 2023
View reviewed changes
Copy link
Contributor Author

@renan061 renan061 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@marcelstanley marcelstanley merged commit a801123 into next Oct 2, 2023
6 checks passed
@marcelstanley marcelstanley deleted the feature/authority-claimer-broker-listener branch October 2, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

@marcelstanley marcelstanley marcelstanley approved these changes

@torives torives Awaiting requested review from torives

Assignees

@renan061 renan061

@marcelstanley marcelstanley

Labels
no changelog PRs that don't require changes in changelog
Projects
Node Unit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement broker for authority-claimer
4 participants
@renan061 @marcelstanley @gligneul @torives