-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add upgrade guide for v.1.5 #507
Conversation
ee0e655
to
a7189df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth noting that the new History will contain no claims, and that they will need to be submitted by the Authority again, one by one.
Might be interesting also to run these cast
commands locally, on a local fork or local devnet, and show an example of the expected output, so that users can know if they're following the migration guide correctly.
Also, would be interesting to show how these read and write functions can be called on Etherscan. Might be a more friendly UI for less seasoned web3 developers. We have contracts verified for the main networks, and one can easily call read-only functions (such as calculateHistoryAddress
, and, after connecting their browser wallets, submit state-changing txs (such as newHistory
and setHistory
). In this case, screenshots might be useful.
0ffb064
to
a2dab18
Compare
Added note
Sure, that was always the plan! I've just added that to the PR description above.
That would be a nice addition. Perhaps we should move this whole guide to the wiki, then. 🤔 Thanks a lot for your help, @guidanoli! |
a2dab18
to
f68869e
Compare
0f6237c
to
92b8b68
Compare
2f00199
to
9837d0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Relates to #432. Requirement for v1.5
Evidence that the steps were executed on devnet and that inputs/outputs from v1.4.0 match the ones in v1.5.0 after the upgrade is complete: