Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: close epochs based on block numbers #445

Merged
merged 3 commits into from
Jul 5, 2024
Merged

fix!: close epochs based on block numbers #445

merged 3 commits into from
Jul 5, 2024

Conversation

renan061
Copy link
Contributor

No description provided.

@renan061 renan061 added bug Something isn't working ! High priority labels Jun 13, 2024
@renan061 renan061 self-assigned this Jun 13, 2024
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch 3 times, most recently from 66346f8 to 6316eeb Compare June 13, 2024 06:17
@marcelstanley marcelstanley changed the title fix: make the dispatcher deterministic Fix ClaimMismatch on v1.x Jun 13, 2024
@renan061 renan061 changed the base branch from release/1.4.x to main June 13, 2024 20:36
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch 6 times, most recently from eb8ed90 to 3aabb53 Compare June 15, 2024 18:36
@renan061 renan061 changed the title Fix ClaimMismatch on v1.x fix: fix claim-mismatch on v.1x Jun 15, 2024
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from 3aabb53 to 9f50e8c Compare June 15, 2024 18:52
@renan061 renan061 marked this pull request as ready for review June 15, 2024 18:52
@renan061 renan061 requested a review from a team June 15, 2024 18:52
@renan061 renan061 linked an issue Jun 15, 2024 that may be closed by this pull request
[v.1.4.0] ClaimMismatch on authority-claimer #432
Closed
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from 9f50e8c to 7174494 Compare June 17, 2024 18:05
marcelstanley
marcelstanley reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@marcelstanley marcelstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions after a first round:

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
offchain/dispatcher/src/drivers/context.rs Show resolved Hide resolved
offchain/dispatcher/src/drivers/context.rs Outdated Show resolved Hide resolved
offchain/dispatcher/src/drivers/mock.rs Outdated Show resolved Hide resolved
offchain/dispatcher/src/drivers/mock.rs Outdated Show resolved Hide resolved
offchain/dispatcher/src/drivers/context.rs Outdated Show resolved Hide resolved
offchain/dispatcher/src/drivers/context.rs Outdated Show resolved Hide resolved
offchain/dispatcher/src/drivers/context.rs Outdated Show resolved Hide resolved
@marcelstanley
Copy link
Collaborator

marcelstanley commented Jun 18, 2024 •
edited
Loading

BTW, @renan061, I'd suggest changing the commit message to something like

fix: close epochs based on block numbers

And then, give more details in a few additional lines

@marcelstanley marcelstanley requested a review from a team June 18, 2024 00:46
marcelstanley
marcelstanley reviewed Jun 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@marcelstanley marcelstanley requested a review from vfusco June 19, 2024 13:25
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from 7174494 to 1f7ed27 Compare June 19, 2024 14:32
@renan061
Copy link
Contributor Author

BTW, @renan061, I'd suggest changing the commit message to something like

fix: close epochs based on block numbers

And then, give more details in a few additional lines

Changed to:

fix!: close epochs based on block numbers

- Fixes the ClaimMismatch bug on v.1x.
- BREAKING CHANGE: replaces the CARTESI_EPOCH_DURATION environment
  variable with CARTESI_EPOCH_LENGTH_IN_BLOCKS.

@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from 1f7ed27 to 679c183 Compare June 19, 2024 14:47
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from a3ad675 to 70c5816 Compare June 24, 2024 23:42
marcelstanley
marcelstanley reviewed Jun 27, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from 70c5816 to 98e532c Compare July 4, 2024 19:10
marcelstanley
marcelstanley previously requested changes Jul 5, 2024
View reviewed changes
setup_env.sh Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch 3 times, most recently from 9ed81ad to 55cc113 Compare July 5, 2024 19:55
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch 3 times, most recently from 1cf7dae to f4a1d17 Compare July 5, 2024 20:06
vfusco
vfusco requested changes Jul 5, 2024
View reviewed changes
offchain/dispatcher/src/drivers/context.rs Outdated Show resolved Hide resolved
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from f4a1d17 to 794ca72 Compare July 5, 2024 21:52
vfusco
vfusco previously approved these changes Jul 5, 2024
View reviewed changes
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from 794ca72 to 6f2138a Compare July 5, 2024 22:08
@renan061
fix!: close epochs based on block numbers
8bbfa17 
- Fixes the ClaimMismatch bug on v.1x.
- BREAKING CHANGE: some environment variables have changed, check the
  CHANGELOG.
@renan061 renan061 force-pushed the fix/ultimate-claim-mismatch branch from 6f2138a to 8bbfa17 Compare July 5, 2024 22:16
@marcelstanley marcelstanley self-requested a review July 5, 2024 22:40
@marcelstanley marcelstanley dismissed their stale review July 5, 2024 22:57

changes accepted

@renan061 renan061 merged commit 935291a into main Jul 5, 2024
6 checks passed
@renan061 renan061 deleted the fix/ultimate-claim-mismatch branch July 5, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelstanley marcelstanley marcelstanley approved these changes

@vfusco vfusco vfusco approved these changes

@fmoura fmoura Awaiting requested review from fmoura

@torives torives Awaiting requested review from torives

Assignees

@renan061 renan061

Labels
! High priority bug Something isn't working
Projects
Node Unit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v.1.4.0] ClaimMismatch on authority-claimer
5 participants
@renan061 @marcelstanley @fmoura @vfusco @torives