Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script for generating a test devnet #168

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Add script for generating a test devnet #168

merged 2 commits into from
Dec 13, 2023

Conversation

marcelstanley
Copy link
Contributor

@marcelstanley marcelstanley commented Nov 22, 2023 •
edited
Loading

Closes #149

@marcelstanley marcelstanley changed the base branch from main to next November 22, 2023 23:07
@marcelstanley marcelstanley force-pushed the feature/cmd-devnet branch 9 times, most recently from 947d220 to 83185ee Compare November 23, 2023 22:05
gligneul
gligneul reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to look good :)

@marcelstanley marcelstanley self-assigned this Nov 23, 2023
Base automatically changed from next to main December 4, 2023 20:31
@gligneul gligneul added the #feat:tests Feature: tests label Dec 4, 2023
@marcelstanley marcelstanley changed the title Feature/cmd devnet Add script for generating a test devnet Dec 5, 2023
@marcelstanley marcelstanley added the no changelog PRs that don't require changes in changelog label Dec 5, 2023
@marcelstanley marcelstanley marked this pull request as ready for review December 5, 2023 02:09
@marcelstanley marcelstanley requested a review from a team December 5, 2023 02:09
@marcelstanley marcelstanley force-pushed the feature/cmd-devnet branch 3 times, most recently from 8970d53 to ea122fe Compare December 5, 2023 02:19
@gligneul gligneul requested a review from renan061 December 5, 2023 13:33
@gligneul gligneul removed the request for review from a team December 5, 2023 17:19
gligneul
gligneul approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@gligneul gligneul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This amount of bash makes me uneasy. We should spend little time improving this code because only a hacker like @marcelstanley can maintain it. We should move on, and I will create an issue to rewrite this in Go.

@marcelstanley
Copy link
Contributor Author

marcelstanley commented Dec 8, 2023 •
edited
Loading

This amount of bash makes me uneasy. We should spend little time improving this code because only a hacker like @marcelstanley can maintain it. We should move on, and I will create an issue to rewrite this in Go.

I agree that even with all code generalization and care, this amounts to too much bash code. Let's move on.

P.S.: I'm not a hacker. 😜

@gligneul gligneul requested review from fmoura and removed request for renan061 December 11, 2023 17:33
@marcelstanley marcelstanley merged commit d335c11 into main Dec 13, 2023
6 checks passed
@marcelstanley marcelstanley deleted the feature/cmd-devnet branch December 13, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligneul gligneul gligneul approved these changes

@fmoura fmoura fmoura approved these changes

Assignees

@marcelstanley marcelstanley

Labels
#feat:tests Feature: tests no changelog PRs that don't require changes in changelog
Projects
Node Unit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shell script gen-devnet to generate the Anvil state
3 participants
@marcelstanley @fmoura @gligneul