Fix duplicate checker verification #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
renan061
suggested changes
Nov 16, 2023
gligneul
suggested changes
Nov 16, 2023
Comment on lines
114
to
131
| let current_block = self | ||
| .provider | ||
| .get_block_number() | ||
| .await | ||
| { | ||
| // If there's any response, the claim already exists | ||
| Ok(_response) => Ok(true), | ||
| Err(e) => { | ||
| // If there's an InvalidClaimIndex error, we're asking for an index | ||
| // bigger than the current one, which means it's a new claim | ||
| if e.to_string().contains("InvalidClaimIndex()") { | ||
| Ok(false) | ||
| } else { | ||
| info!("{:?}", e); | ||
| Err(e).context(ContractSnafu) | ||
| } | ||
| } | ||
| .context(ProviderSnafu)? | ||
| .as_u64(); |
There was a problem hiding this comment.
This will not work properly if a reorg happens. With the state-fold code, we looked N blocks behind to be sure. We should do the same here.
There was a problem hiding this comment.
Just pushed a fix that should solve this issue
Read the NewClaimToHistory event from the History contract instead of calling the getClaim method from the Authority contract. Co-authored-by: Gabriel de Quadros Ligneul <[email protected]>
GMKrieger
force-pushed
the
feature/fix-duplicate-checker
branch
from
7019ae7 to
75e9b78
Compare
renan061
approved these changes
Nov 16, 2023
gligneul
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the NewClaimToHistory event from the History contract instead of calling the getClaim method from the Authority contract.