Pin Rust to version 1.72.x #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust version 1.73.0 introduced new warnings, and made some dispatcher tests start failing. Pining the Rust version will allow the CI checks to pass and postpone the need to update the Rust codebase.
torives
force-pushed
the
feature/rust-version
branch
from
c0dac21 to
e963199
Compare
torives
changed the title
marcelstanley
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Rust version in the
ubuntu-22.04image used in our Github Action workflows was upgraded to Rust 1.73.0. This new version introduced new warnings, and made somedispatchertests start failing.As we're in the process of migrating from Rust to Go, fixing this is not high on our priority list. Pining the Rust version will allow the CI to continue working and postpone the need to deal with these problems.