Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add infrastructure to run node #110

Closed
wants to merge 2 commits into from
Closed

Conversation

fmoura
Copy link
Contributor

@fmoura fmoura commented Oct 1, 2023

No description provided.

@fmoura fmoura linked an issue Oct 1, 2023 that may be closed by this pull request
8 tasks
@fmoura fmoura self-assigned this Oct 2, 2023
@fmoura fmoura force-pushed the feature/add-infra branch 2 times, most recently from 6fa7a76 to 85c388e Compare October 6, 2023 19:38
@fmoura fmoura force-pushed the feature/add-infra branch 2 times, most recently from 3348331 to cf99295 Compare October 27, 2023 13:55
@fmoura fmoura force-pushed the feature/add-infra branch from 6be0791 to c2d28d5 Compare November 9, 2023 17:53
As cartesi-rollups-node gets built and new services are added, it becomes
increasingly cumbersome to set up an environment to test it. The added docker-compose file is meant to simplify the process of manual testing for the
time being
@fmoura fmoura added the no changelog PRs that don't require changes in changelog label Nov 16, 2023
context: ./anvil-base
dockerfile: ./Dockerfile
tags:
- "cartesi/anvil:devel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name of the image should be cartesi/rollups-node-devnet:devel.

@@ -0,0 +1,6 @@
target "docker-metadata-action" {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these bake files? Are they necessary when using docker-compose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I left them as an Option to build them. But giving it a second thought It is cleaner to have them removed

build/README.md Outdated
cast send $INPUT_BOX_ADDRESS "addInput(address,bytes)(bytes32)" $DAPP_ADDRESS $INPUT --mnemonic "test test test test test test test test test test test junk" --rpc-url "http://localhost:8545"
```

## query input
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## query input
## Query input

build/README.md Outdated
Comment on lines 42 to 46
Access `http://localhost:4000/graphql` and execute query
```
query{
notices {edges{node{index,payload,input{payload}}}}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can export a curl example in the GraphQL. It would be clearer instead of asking the person to open the browser.

@@ -0,0 +1,22 @@
# syntax=docker.io/docker/dockerfile:1.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing copyright.

@@ -0,0 +1,30 @@
# (c) Cartesi and individual authors (see AUTHORS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be rebased on top of next.

.gitignore Outdated
Comment on lines 4 to 7
build/deployments
**/.idea/
build/anvil/anvil_state/state.json
build/anvil/deployments/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need two deployment directories (one in build and another in anvil)?

@fmoura fmoura changed the base branch from main to next November 17, 2023 03:28
@gligneul gligneul closed this Nov 27, 2023
@torives torives deleted the feature/add-infra branch February 9, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs that don't require changes in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add infra for manual tests
3 participants