Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some log messages to improve troubleshooting #308

Closed
5 of 6 tasks
endersonmaia opened this issue Feb 5, 2024 · 4 comments · Fixed by #322
Closed
5 of 6 tasks

Some log messages to improve troubleshooting #308

endersonmaia opened this issue Feb 5, 2024 · 4 comments · Fixed by #322
Assignees
Labels
#feat:go-supervisor Feature: Go supervisor
Milestone

Comments

@endersonmaia
Copy link
Contributor

endersonmaia commented Feb 5, 2024

📚 Context

While deploying rollups-node, we need to check if everything is ok right after it starts.

I still miss some logs that would be nice to have.

✔️ Solution

  • Log the rollups-node version when it starts.
  • Ensure the rollups-node version matches the Rust services version to avoid confusion
  • Log which AUTH_* method is being used
  • Provide a single line of error for each problem found in the configuration
  • Log all configuration errors at once to avoid multiple node restarts in quick succession
  • Use ISO 8601 as the date format
@gligneul gligneul added the #feat:go-supervisor Feature: Go supervisor label Feb 5, 2024
@gligneul gligneul added this to the 1.3.0 milestone Feb 5, 2024
@gligneul
Copy link
Contributor

gligneul commented Feb 5, 2024

some internal rust daemons are still being logged as 1.2.0, and that may be confusing

This should be fixed regardless.

log which AUTH_ method is being used

Makes sense

@gligneul gligneul moved this to 🏗 In progress in Node Unit Feb 5, 2024
@gligneul gligneul moved this from 🏗 In progress to 📋 Backlog in Node Unit Feb 5, 2024
@gligneul gligneul modified the milestones: 1.3.0, 1.4.0 Feb 9, 2024
@torives torives self-assigned this Feb 12, 2024
@torives torives moved this from 📋 Backlog to 🏗 In progress in Node Unit Feb 12, 2024
@gligneul gligneul moved this from 🏗 In progress to 👀 In review in Node Unit Mar 21, 2024
@torives
Copy link
Contributor

torives commented Mar 21, 2024

@endersonmaia We'll drop the requirement of listing all configuration errors at once. The Node Unit is now focusing on tasks related to the new major 2.0 release, so we'll deprioritize this. Feel free to contribute with a PR, though. I can give you some pointers 😉

@endersonmaia
Copy link
Contributor Author

@torives I converted the list on this issue description to check boxes, could you mark if any of the items are already implemented, then I'll see if I can take one.

@torives
Copy link
Contributor

torives commented Mar 22, 2024

@endersonmaia #322 should solve all of them except the previously mentioned one.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Node Unit Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#feat:go-supervisor Feature: Go supervisor
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants