Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UArchReset test case #64

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Add UArchReset test case #64

merged 8 commits into from
Apr 24, 2024

Conversation

stephenctw
Copy link
Contributor

Add UArchReset.t.sol test to validate hashes before and after the reset operation logged in uarch-reset-log.json

@stephenctw stephenctw self-assigned this Mar 12, 2024
@stephenctw stephenctw force-pushed the feature/ureset-test branch from 396fb1f to 373eebb Compare March 12, 2024 12:32
@stephenctw
Copy link
Contributor Author

stephenctw commented Mar 12, 2024

@GCdePaula could you take a look at the change I made to Memory.sol? The alignment check for size and address seems to be misaligned in the old implementation. position is counted in word size, and the size is counted in byte size.

@stephenctw stephenctw force-pushed the feature/ureset-test branch from 373eebb to 21e8347 Compare March 12, 2024 12:55
@stephenctw stephenctw force-pushed the feature/ureset-test branch from d538c68 to 634da3b Compare April 13, 2024 11:25
@mpernambuco mpernambuco force-pushed the feature/ureset-test branch from 6c3f2ba to 28ff4b0 Compare April 23, 2024 20:42
@mpernambuco mpernambuco requested a review from vfusco April 23, 2024 21:17
@vfusco vfusco merged commit 28ff4b0 into main Apr 24, 2024
2 checks passed
@vfusco vfusco deleted the feature/ureset-test branch April 24, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants