Increase word log2 size #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpernambuco
force-pushed
the
increase-word-log2-size
branch
from
ac5f0f2 to
99ea5e0
Compare
mpernambuco
force-pushed
the
increase-word-log2-size
branch
from
18482e4 to
e8a9aba
Compare
edubart
reviewed
Jul 23, 2024
mpernambuco
force-pushed
the
increase-word-log2-size
branch
from
e8a9aba to
bc6fca8
Compare
|
I approve with remarks that |
edubart
previously approved these changes
Jul 29, 2024
mpernambuco
force-pushed
the
increase-word-log2-size
branch
from
bc6fca8 to
22a73e3
Compare
edubart
previously approved these changes
Jul 29, 2024
mpolitzer
previously approved these changes
Jul 29, 2024
diegonehab
reviewed
Aug 1, 2024
diegonehab
reviewed
Aug 1, 2024
diegonehab
reviewed
Aug 1, 2024
diegonehab
reviewed
Aug 1, 2024
diegonehab
reviewed
Aug 1, 2024
diegonehab
reviewed
Aug 1, 2024
diegonehab
reviewed
Aug 1, 2024
diegonehab
previously requested changes
Aug 1, 2024
mpernambuco
force-pushed
the
increase-word-log2-size
branch
from
22a73e3 to
0721f0a
Compare
edubart
previously approved these changes
Aug 1, 2024
mpolitzer
previously approved these changes
Aug 1, 2024
mpernambuco
force-pushed
the
increase-word-log2-size
branch
2 times, most recently
from
6cd4894 to
3aaee22
Compare
edubart
reviewed
Aug 6, 2024
mpernambuco
force-pushed
the
increase-word-log2-size
branch
from
3aaee22 to
451a0fe
Compare
edubart
reviewed
Aug 6, 2024
mpernambuco
force-pushed
the
increase-word-log2-size
branch
from
451a0fe to
70d0530
Compare
mpernambuco
force-pushed
the
increase-word-log2-size
branch
from
70d0530 to
e6bf24e
Compare
edubart
approved these changes
Aug 6, 2024
mpolitzer
approved these changes
Aug 6, 2024
vfusco
dismissed
diegonehab’s stale review
Diego reviewed and had only minor comments that were already addressed. Dismissing so we can move forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch increases the merkle tree leaf size to 32 bytes.
We are still able to log accesses to data smaller than 32 bytes. We log the entire 32-byte leaf where the smaller data is located.
Related PR
cartesi/machine-solidity-step#68