Add copyright (license) to machine-emulator-tools.deb #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edubart
previously approved these changes
Sep 18, 2024
diegonehab
requested changes
Sep 18, 2024
Dockerfile
Outdated
| @@ -175,6 +175,7 @@ RUN mkdir -p ${STAGING_DEBIAN} ${STAGING_SBIN} ${STAGING_BIN} ${STAGING_BASE}/et | |||
| COPY control ${STAGING_DEBIAN}/control | |||
| COPY package.json ${STAGING_SHARE}/package.json | |||
| COPY postinst ${STAGING_DEBIAN}/postinst | |||
| COPY LICENSE ${STAGING_BASE}/usr/share/doc/machine-emulator-tools/copyright | |||
There was a problem hiding this comment.
I don't think this is the format of the copyright file.
Please see copyright format.
There was a problem hiding this comment.
I don't think this is the format of the copyright file. Please see copyright format.
Format did not exist for the ubuntu version in use.
Updated for versions 24.04+ conformance.
There was a problem hiding this comment.
This is what the thing looks like after running the automatic license extractor.
The source will only show up when we have upstreamed the package, right?
### `dpkg` source package: `machine-emulator-tools=0.16.2`
Binary Packages:
- `machine-emulator-tools=0.16.2`
Licenses: (parsed from: `/usr/share/doc/machine-emulator-tools/copyright`)
- `Apache-2.0`
**WARNING:** unable to find source (`apt-get source` failed or returned no results)!
This is *usually* due to a new package version being released and the old version being removed.
There was a problem hiding this comment.
The source will only show up when we have upstreamed the package, right?
Either that or having a /etc/apt/sources.list|/etc/apt/sources.list.d/ entry pointing to our own "PPA".
mpolitzer
force-pushed
the
fix/license
branch
from
98c7c3e to
613f7cf
Compare
diegonehab
approved these changes
Sep 20, 2024
edubart
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #82