feat: add xgenext2fs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolitzer
force-pushed
the
feat/add-xgenext2fs
branch
4 times, most recently
from
77ceccc to
d17b44f
Compare
mpolitzer
force-pushed
the
feat/add-xgenext2fs
branch
from
d17b44f to
146dcee
Compare
vfusco
approved these changes
Nov 30, 2023
alexmikhalevich
approved these changes
Nov 30, 2023
| wget vim wget curl zip unzip libexpat-dev python3 help2man && \ | ||
| rm -rf /var/lib/apt/lists/* | ||
|
|
||
| RUN \ | ||
| wget -O /tmp/xgenext2fs.deb https://github.com/cartesi/genext2fs/releases/download/v1.15.3/xgenext2fs_${TARGETARCH}.deb && \ |
There was a problem hiding this comment.
do you think it makes sense to move the version to the env var here?
There was a problem hiding this comment.
But I'm actually ambivalent to it.
But we'll have to edit this file on any change to xgenext2fs either way due to the checksums.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #16