Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/adapt to rollups 1.2.0 #72

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Feature/adapt to rollups 1.2.0 #72

merged 2 commits into from
Dec 5, 2023

Conversation

endersonmaia
Copy link
Collaborator

@endersonmaia endersonmaia commented Nov 13, 2023 •
edited
Loading

TODO:

  • stop using volume for /deployments/$network/dapp.json with --dapp-deployment-file and get values.yaml using specific parameters;
  • stop using volume for /opt/cartesi/share/deployments/$network.json and --rollups-deployment-file and get from values.yaml using specific parameters;
    - [ ] clean redis streams by default using an entrypoint for rollups-dispatcher container

@endersonmaia endersonmaia self-assigned this Nov 13, 2023
omidasadpour
omidasadpour suggested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@omidasadpour omidasadpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I want to deploy the chart in sepolia the dispatcher and authority server crashed.

Error: BlockchainError { source: JsonReadError { path: "/opt/cartesi/share/deployments/sepolia.json", source: Error("missing field `History`", line: 1200, column: 3) } }

@endersonmaia endersonmaia force-pushed the feature/adapt-to-rollups-1.2.0 branch from 20d2b64 to 8326e38 Compare December 4, 2023 09:55
omidasadpour
omidasadpour suggested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@omidasadpour omidasadpour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anvil version should update to 3.1.0 (the current version does not exist in our docker repo anymore)

@endersonmaia endersonmaia force-pushed the feature/adapt-to-rollups-1.2.0 branch 2 times, most recently from d8c38d8 to 918d775 Compare December 4, 2023 18:10
@endersonmaia endersonmaia force-pushed the feature/adapt-to-rollups-1.2.0 branch from 918d775 to a616794 Compare December 4, 2023 18:11
@omidasadpour omidasadpour self-requested a review December 5, 2023 11:28
omidasadpour
omidasadpour approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@omidasadpour omidasadpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just update the Readme

@endersonmaia
Copy link
Collaborator Author

Let's just update the Readme

Can you send a PR?

@endersonmaia endersonmaia merged commit 81bf768 into main Dec 5, 2023
4 checks passed
@endersonmaia endersonmaia deleted the feature/adapt-to-rollups-1.2.0 branch December 5, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omidasadpour omidasadpour omidasadpour approved these changes

@tuler tuler Awaiting requested review from tuler

Assignees

@endersonmaia endersonmaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@endersonmaia @omidasadpour