Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image for cartesi machine download #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tuler
Copy link
Member

@tuler tuler commented Aug 16, 2023

This creates a docker image used to download cartesi machine snapshot from IPFS.
It uses the ipget go package.

This image will be used as an initContainer of a rollups node.

@tuler tuler requested a review from endersonmaia August 16, 2023 16:46
@tuler tuler force-pushed the feature/machine-download branch from ff2e1da to 1290f55 Compare August 16, 2023 16:48
Base automatically changed from feature/monorepo to main August 16, 2023 16:58
@tuler tuler force-pushed the feature/machine-download branch from 1290f55 to 6ec6549 Compare August 16, 2023 16:59
@@ -0,0 +1,69 @@
name: machine-download
on:
workflow_call:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretend to use this as a workflow? if not, remove this line

Suggested change
workflow_call:
workflow_call:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to use changesets here?

This was this way because of changesets

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure.

It won't hurt keeping it that, anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case what is missing here is a release strategy, either manual tagging or changesets.

What is the strategy of helm? Manual or automated?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the charts/, it's automated.

Tha tags are made by the CI after the charts hits the main branch, we have a release via GH Pages, to host the helm legacy way, and also use ghcr.io for the OCI Reistry way of releasing helm charts.

I think we should deprecate the old way, and keep only the OCI Registry option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does it make sense to let changesets take control of the “landing on main”, and delegate the release to a workflow call?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd have to test.

The ct tool used to release already tags, won't it conflict with the changests tagging process?

Comment on lines +4 to +5
FROM debian:bookworm-20230725
COPY --from=builder /go/bin/ipget /usr/local/bin/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FROM debian:bookworm-20230725
COPY --from=builder /go/bin/ipget /usr/local/bin/
FROM debian:bookworm-20230814-slim
COPY --from=builder /go/bin/ipget /usr/local/bin/
RUN addgroup --system --gid 102 cartesi && \
adduser --system --uid 102 --ingroup cartesi --disabled-login --no-create-home --home /nonexistent --gecos "cartesi user" --shell /bin/false cartesi
USER cartesi
ENTRYPOINT [ "ipget" ]

@tuler tuler force-pushed the feature/machine-download branch from 6ec6549 to 74b072e Compare October 4, 2023 02:36
@tuler tuler force-pushed the feature/machine-download branch from 74b072e to 68cdea1 Compare October 4, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants